Skip to content

chore: add standalone target with plugin caching #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 77 commits into
base: main
Choose a base branch
from
Open

chore: add standalone target with plugin caching #1062

wants to merge 77 commits into from
+318 −80

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Aug 12, 2025 •
edited
Loading

Followup of:

Precondition:

This PR includes:

  • add helper to load envVars
  • adjusted nx.json
    • add defaultTargets for main and plugin code-pushup targets
    • add default inputs
  • add plugin caching to code-pushup target
  • cache js-packages and invalidate daily
  • GH adjustments
    • added affected and --parallel=3
  • Adjust path helper that that created Nx project graph to use readCachedProjectGraph to avoid problems when running plugins in parallel

Note

I cache the js-packges plugin target, against our discussion, as only in this PR I would have saved ~4min

Followup Todos:

  • move zod2md.ts under tools and leverage "!{projectRoot}/tools/**/*" in nx.json#namedInputs.production
  • rename nx-plugin/mock to models/mocks and adjust inputs
  • cleanup e2e targets leverage nx.json#targetDefaults
  • include only relevant projects in plugin-eslint config
  • stricter task dependencies to avoid running tracked libs e.g. nx run test-nx-utils:unit-test is executed ATM
  • understand why e2e tests fail if nx.json#defaultTargets[N].@nx/vite:test as empty ({}) target is removed

Followup PRs:

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 12, 2025 •
edited
Loading

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1062

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1062

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1062

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1062

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1062

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1062

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1062

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1062

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1062

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1062

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1062

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1062

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1062

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1062

commit: 24c8e4b

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2025 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 12c5b00 with previous commit 5b4069a.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 32 🔴 32 ↓ −0.3
Code coverage 🟢 91 🟢 90 ↓ −0.1
Documentation 🔴 23 🔴 23 ↑ +0.1
Security 🟡 64 🟡 64 –
Updates 🟡 85 🟡 85 –
Accessibility 🟢 92 🟢 92 –
Best Practices 🟢 100 🟢 100 –
SEO 🟡 61 🟡 61 –
Type Safety 🟢 100 🟢 100 –
Bug prevention 🟢 100 🟢 100 –
Miscellaneous 🟢 100 🟢 100 –
Code style 🟢 100 🟢 100 –
👍 1 group improved, 👎 2 groups regressed, 👍 3 audits improved, 👎 5 audits regressed, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 32 🔴 32 ↓ −0.3
Code coverage Code coverage metrics 🟢 91 🟢 90 ↓ −0.1
JSDoc coverage Documentation coverage 🔴 23 🔴 23 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 680 ms 🟩 Root document took 560 ms ↓ −18.5 %
Lighthouse Speed Index 🟥 7.9 s 🟥 7.3 s ↓ −8.3 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.3 s ↑ +4.2 %
Lighthouse Total Blocking Time 🟥 3,240 ms 🟥 4,410 ms ↑ +35.9 %
JSDoc coverage Functions coverage 🟥 519 undocumented functions 🟥 519 undocumented functions +0 %
Code coverage Function coverage 🟩 93.1 % 🟩 93 % ↓ −0.1 %
Code coverage Line coverage 🟨 87.6 % 🟨 87.5 % ↓ −0.1 %
Code coverage Branch coverage 🟨 86.4 % 🟨 86.3 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟨 Total size was 2,674 KiB 🟨 Total size was 2,679 KiB ↑ +0.2 %
Lighthouse Minimizes main-thread work 🟥 12.3 s 🟥 15.0 s ↑ +21.9 %
Lighthouse JavaScript execution time 🟥 5.0 s 🟥 7.1 s ↑ +40.9 %
Lighthouse Max Potential First Input Delay 🟥 1,850 ms 🟥 1,520 ms ↓ −18.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 582 KiB 🟥 Potential savings of 582 KiB ↑ +23.1 %
Lighthouse Server Backend Latencies 🟩 1,590 ms 🟩 1,780 ms ↑ +11.8 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 113 KiB 🟥 Potential savings of 113 KiB ↑ +39.1 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 100 KiB 🟥 Potential savings of 100 KiB ↑ +60 %
Lighthouse Time to Interactive 🟥 18.2 s 🟥 18.1 s ↓ −0.8 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −0.8 %
Lighthouse Largest Contentful Paint 🟥 12.1 s 🟥 12.1 s ↑ +0.3 %
Lighthouse Avoids an excessive DOM size 🟥 2,277 elements 🟥 2,271 elements ↓ −0.3 %
Lighthouse Network Round Trip Times 🟩 40 ms 🟩 40 ms ↑ +8.2 %
JS Packages Outdated NPM dev dependencies. 🟨 49 outdated package versions (21 major, 23 minor, 5 patch) 🟨 50 outdated package versions (21 major, 23 minor, 6 patch) ↑ +2 %

587 other audits are unchanged.

@BioPhoton BioPhoton changed the title chore: add env var helper chore: add plugin targets Aug 12, 2025
@github-actions github-actions bot added the 🦾 CI/CD Continuous integration and deployment label Aug 12, 2025
@github-actions github-actions bot added the 📖 Project documentation improvements or additions to the project documentation label Aug 13, 2025
@BioPhoton BioPhoton mentioned this pull request Aug 13, 2025
Draft
@BioPhoton BioPhoton marked this pull request as ready for review August 14, 2025 11:19
@BioPhoton BioPhoton requested a review from matejchalk August 14, 2025 11:22
@github-actions github-actions bot removed 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 nx-plugin labels Aug 16, 2025
@github-actions github-actions bot added the 🔬 testing writing tests label Aug 22, 2025
@github-actions github-actions bot removed the 🔬 testing writing tests label Aug 22, 2025
BioPhoton
BioPhoton commented Aug 22, 2025
View reviewed changes
matejchalk
matejchalk previously approved these changes Aug 25, 2025
View reviewed changes
@BioPhoton BioPhoton requested a review from matejchalk August 27, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejchalk matejchalk matejchalk approved these changes

Assignees

@BioPhoton BioPhoton

Labels
🦾 CI/CD Continuous integration and deployment 🧩 coverage-plugin 🧩 eslint-plugin 🛠️ tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BioPhoton @matejchalk